Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #25: /opt/gemstone/log is default if GEMSTONE_LOGDIR not defined #26

Merged
merged 1 commit into from
Jan 30, 2015

Conversation

dalehenrich
Copy link
Member

No description provided.

@krono
Copy link
Member

krono commented Jan 30, 2015

What about just spilling to stdout or stderr when logdir is not present?

dalehenrich added a commit that referenced this pull request Jan 30, 2015
Issue #25: /opt/gemstone/log is default if GEMSTONE_LOGDIR not defined
@dalehenrich dalehenrich merged commit eec8f96 into master Jan 30, 2015
@dalehenrich
Copy link
Member Author

@krono when the gem server is launched from another process (like tODE), stdout is lost and it isn't possible to debug server/script problems, so some sort of default location is needed ... the primary use case for gem servers is the GsDevKitHome environment, but I've got some internal tests that aren't run in GsDevKitHome and I was having a devil of a time figuring out why the tests were failing without log files...

@krono
Copy link
Member

krono commented Jan 30, 2015

thanks, sounds reasonable

@dalehenrich
Copy link
Member Author

It might be useful to have an option to bypass the log file and spill to stdout (personally I tail the log file when I want to monitor the log). Submit an issue if you'd like to have that as a feature..

@krono
Copy link
Member

krono commented Jan 30, 2015

It'll be part of the daemontools related stuff anyway

@dalehenrich
Copy link
Member Author

hopefully as an option to spill to standard out ... the gem log files still need to be located on disk in a well-known location

@krono
Copy link
Member

krono commented Jan 30, 2015

In what sense?
Under daemontools with multilog, the stdout/stderr would end up in a (for this tools) well-known location, but definitely not all in the same directory, but rather an gem-instance specific one

@dalehenrich
Copy link
Member Author

That's not the way I run ss3 (with daemontools) and I'm not sure that I personally like having log files located all "over the place". I'm used to hitting the log dir and looking at the latest files there without having to "wander around":)

Also for GsDevKit, when I am trying to help users, I want to be able to say that they can find the log file in #GEMSTONE_LOGDIR and not have to qualify my statements with "if you are using blah, look here and if you using beh, look there".

With that aid, I have no problem with allowing people to put logs anywhere they please. The defaults are only there to get folks to the point where they can have an informed opinion and decide where things should go ...

@krono
Copy link
Member

krono commented Jan 30, 2015

No problem, nor any request intended ;)
Any more info in the upcoming issue(s) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants